Refactor and Enhance Docker Scout Integration #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
… CYT-828-add-plugin-command
for more information, see https://pre-commit.ci
… CYT-828-add-plugin-command
for more information, see https://pre-commit.ci
Simpler string formatting. Co-authored-by: Ryan Mast <[email protected]>
Fixed typo. Co-authored-by: Ryan Mast <[email protected]>
…LNL/Surfactant into CYT-1123-plugin-enable-disable
for more information, see https://pre-commit.ci
Co-authored-by: Ryan Mast <[email protected]>
- Introduced DockerScoutManager class to manage Docker Scout installation checks and state. - Added error handling for JSON decoding in run_docker_scout function. - Implemented init_hook to initialize Docker Scout status, excluding update-db command. - Improved code readability with docstrings and structured initialization.
for more information, see https://pre-commit.ci
…tant into cyt-1163-init-docker
nightlark
approved these changes
Jan 14, 2025
nightlark
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the integration of Docker Scout within the codebase and introduces several improvements:
DockerScoutManager Class: A new class, DockerScoutManager, is introduced to encapsulate the logic for checking Docker Scout installation status and managing its state. This improves code organization and readability.
Error Handling: Enhanced error handling in the run_docker_scout function by adding a json.JSONDecodeError exception to handle potential JSON parsing errors, ensuring robustness in processing Docker Scout outputs.
Initialization Hook: Added an init_hook function to initialize Docker Scout status when the module is loaded, except when the command is "update-db". This ensures that Docker Scout's availability is checked and logged appropriately.
Code Readability: Improved code readability by adding docstrings to functions and methods, providing clear descriptions of their purposes and behaviors.