feat: Add configuration option to enable/disable Docker Scout #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
willis89pr
commented
Jan 21, 2025
willis89pr
commented
- Integrated ConfigManager to retrieve 'enable_docker_scout' setting.
- Modified DockerScoutManager to respect the configuration option, allowing users to enable or disable Docker Scout functionality.
- Updated init_hook to conditionally check Docker Scout installation based on configuration.
- Added logic to short-circuit Docker Scout operations if disabled via configuration.
- Integrated ConfigManager to retrieve 'enable_docker_scout' setting. - Modified DockerScoutManager to respect the configuration option, allowing users to enable or disable Docker Scout functionality. - Updated init_hook to conditionally check Docker Scout installation based on configuration. - Added logic to short-circuit Docker Scout operations if disabled via configuration.
for more information, see https://pre-commit.ci
…L/Surfactant into cyt-1171-enable-docker-scout
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
surfactant/infoextractors/docker_image.py:27
- [nitpick] The variable name 'disable_docker_scout' is ambiguous. It should be renamed to 'docker_scout_enabled' for better clarity.
self.disable_docker_scout = not enable_docker_scout
surfactant/infoextractors/docker_image.py:45
- [nitpick] The error message could be clearer. Consider changing it to: 'You can also disable Docker Scout by running 'surfactant config docker.enable_docker_scout false'.'
You can also disable this check by running 'surfactant config docker.enable_docker_scout false'.
nightlark
reviewed
Jan 23, 2025
nightlark
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.