Fix versioning logic for llnl_elcapitan #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scheibelp
approved these changes
Feb 5, 2025
| else: | ||
| self.pmi_version = Version("6.1.12") | ||
| self.llvm_version = Version("16.0.0") | ||
| # TODO: Replace this with lookups into the working set |
There was a problem hiding this comment.
I'm not sure what is meant by "working set" here but the logic in this section looks really good to me: we could later offer variants to control each of these versions individually, but for now this essentially handles the recommended combinations of compiler/rocm/utilities.
There was a problem hiding this comment.
@scheibelp The "working set" is a - yet to be implemented - generalized set of all version dependencies for a given system. That would completely get rid of hard-coded versions from system.py. Still working on the details. I'll go ahead and merge this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the versioning scheme for the llnl_elcapitan system config. This change allows seamlessly creating elcap system instances for different rocm versions.
Adding/modifying a system (docs: Adding a System)
systems/system_name/system.pyfile