Skip to content

Commit

Permalink
Fix CRAN issue about Rf_error in RcppExports.
Browse files Browse the repository at this point in the history
  • Loading branch information
astamm committed Jan 10, 2024
1 parent 6e01d9d commit 13f4b3b
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 15 deletions.
3 changes: 2 additions & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ objects.
* Added function `qts2aats()` which allows to switch from quaternion to
axis-angle representation of rotations.
* Added usual operations `+`, `-`, `*` and `inverse_qts()` for quaternion time
series using the [Eigen](https://eigen.tuxfamily.org) library.
series using the [Eigen](https://eigen.tuxfamily.org/index.php?title=Main_Page)
library.

## Small improvements

Expand Down
20 changes: 11 additions & 9 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,13 +1,6 @@
## Resubmission

This is a resubmission in which I have:

* removed the display of animated plot in the `README` to reduce the size of the
package.

## Test environments

- local macOS R installation, R 4.3.1
- local macOS R installation, R 4.3.2
- continuous integration via GH actions:
- macOS latest release
- windows latest release
Expand All @@ -23,4 +16,13 @@ package.

## R CMD check results

There was no ERROR, no WARNINGs, no NOTEs.
There was no ERROR and no WARNINGs.

There was 1 NOTE (installed size varies depending on the OS):

* checking installed package size ... NOTE
installed size is 13.3Mb
sub-directories of 1Mb or more:
data 1.1Mb
help 1.1Mb
libs 10.8Mb
10 changes: 5 additions & 5 deletions src/RcppExports.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ RcppExport SEXP _squat_GeodesicQuaternionDistance(SEXP M1SEXP, SEXP M2SEXP, SEXP
if (rcpp_isError_gen) {
SEXP rcpp_msgSEXP_gen = Rf_asChar(rcpp_result_gen);
UNPROTECT(1);
Rf_error(CHAR(rcpp_msgSEXP_gen));
Rf_error("%s", CHAR(rcpp_msgSEXP_gen));
}
UNPROTECT(1);
return rcpp_result_gen;
Expand Down Expand Up @@ -86,7 +86,7 @@ RcppExport SEXP _squat_RegularizeGrid(SEXP gridSEXP, SEXP valuesSEXP, SEXP gridL
if (rcpp_isError_gen) {
SEXP rcpp_msgSEXP_gen = Rf_asChar(rcpp_result_gen);
UNPROTECT(1);
Rf_error(CHAR(rcpp_msgSEXP_gen));
Rf_error("%s", CHAR(rcpp_msgSEXP_gen));
}
UNPROTECT(1);
return rcpp_result_gen;
Expand Down Expand Up @@ -120,7 +120,7 @@ RcppExport SEXP _squat_GetGeodesicMean(SEXP valuesSEXP) {
if (rcpp_isError_gen) {
SEXP rcpp_msgSEXP_gen = Rf_asChar(rcpp_result_gen);
UNPROTECT(1);
Rf_error(CHAR(rcpp_msgSEXP_gen));
Rf_error("%s", CHAR(rcpp_msgSEXP_gen));
}
UNPROTECT(1);
return rcpp_result_gen;
Expand Down Expand Up @@ -388,7 +388,7 @@ RcppExport SEXP _squat_gmean(SEXP quaternionSampleSEXP, SEXP maxIterationsSEXP,
if (rcpp_isError_gen) {
SEXP rcpp_msgSEXP_gen = Rf_asChar(rcpp_result_gen);
UNPROTECT(1);
Rf_error(CHAR(rcpp_msgSEXP_gen));
Rf_error("%s", CHAR(rcpp_msgSEXP_gen));
}
UNPROTECT(1);
return rcpp_result_gen;
Expand Down Expand Up @@ -424,7 +424,7 @@ RcppExport SEXP _squat_gmedian(SEXP quaternionSampleSEXP, SEXP maxIterationsSEXP
if (rcpp_isError_gen) {
SEXP rcpp_msgSEXP_gen = Rf_asChar(rcpp_result_gen);
UNPROTECT(1);
Rf_error(CHAR(rcpp_msgSEXP_gen));
Rf_error("%s", CHAR(rcpp_msgSEXP_gen));
}
UNPROTECT(1);
return rcpp_result_gen;
Expand Down

0 comments on commit 13f4b3b

Please sign in to comment.