Allow user input for plugins configurations #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds settings to plugins. issue: #1264
It allows the user to configure the plugins. For example the plugin I'm working on for komga.
The plugin defines the settings in the following format:
pluginSettings = { email: { value: "", label: "Email" }, password: { value: "", label: "Password" }, url: { value: "", label: "URL" } }And the app then adds a cog in the installed plugin like this:
When pressed a modal opens up with the inputs defined in the plugin:
The setting are stored in the plugin storage. An can be accessed by the plugins.
Corrently it only allows text inputs. Maybe in the future other types could be added.
Everything seems to be working but I'm sure there will be problems with this as I'm not very familiar with react. Just point them out, maybe answer a few dumb questions from me that might arise and I'll try to fix them.