fix: handle filenames with underscores in EPUB import process (#1388) #1391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated regex patterns to correctly handle paths and filenames with underscores. - Ensured sanitized path handling for consistent file processing. - Added error logging for path decoding issues. - Improved chapter and static file insertion to prevent errors with special characters. - Refactored path manipulations for better compatibility. Resolves #1388: Fixed issues with importing EPUB files that have underscores in their filenames.
|
I forgot to close that issue, one of the last two merged PRs resolved the bug. Not sure which one. |
|
Thanks for the update! It looks like one of the last two merged PRs has resolved the bug related to importing EPUB files with underscores in the filenames. Since the issue seems to be fixed, I'll close this PR now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request addresses and resolves Issue #1388 related to importing EPUB files with underscores in the filenames. The issue caused failures when processing files with such characters.
Changes made:
Impact: