-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add more translations #908
Conversation
src/screens/settings/SettingsReaderScreen/Settings/CustomCSSSettings.tsx
Outdated
Show resolved
Hide resolved
I know it's too late to change. But do you think getting strings to translate by screens is a gud solution ? @rajarsheechatterjee . |
I initially used this so the context of the string is there while translating. It might not be necessary and also it's making the keys really long. Going forward we can add newer strings directly instead of nesting it. |
Maybe I should rename the keys right away in this PR. |
5ec7560
to
f640cd3
Compare
e34963b
to
67fa44b
Compare
src/screens/settings/SettingsBackupScreen/Components/GoogleDriveModal.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
tried my best to find translatable strings.
there maybe some duplicate strings, don't know if they should be merged together.
assisted by i18n-ally.