-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration for LSST the Docs #283
base: master
Are you sure you want to change the base?
Configuration for LSST the Docs #283
Conversation
This is a basic Sphinx site without any content. It can be built via `make html`. Sphinx build dependencies are included in doc/requirements.txt
The travis configuration builds sphinx docs in the after_success stage. The doc build process consists of - installing extra python dependencies via a requirements.txt - building the sphinx project - uploading the sphinx build to LSST the Docs
Changes Unknown when pulling 35c2810 on jonathansick:issue/251/lsst-the-docs into * on DarkEnergyScienceCollaboration:master*. |
This may be very timely indeed @jonathansick :) As for testing, perhaps we can pull this into a branch in the Twinkles repository? We have travis set up to run on our branches - so would that work in this context? |
Yeah I saw tweets about your Oxford meeting and it reminded me I owed DESC a bit of work :) You can add this branch on https://twinkles.lsst.io/v/issue-251-lsst-the-docs/ The reason a fork like mine can't publish to the Twinkles LTD account is because the credentials can only be decrypted by a Travis job running from the main Trinkles repo... essentially it's a security feature. The main advantage of LTD over gh-pages is that versioning is built-in. Each branch or tag is published independently off of the For a software project like Twinkles, especially one that uses Sphinx, LTD might be more comparable to readthedocs.org. In that case, LTD is more flexible in the doc build environment than readthedocs.org. RTD has a few extra features at the moment (like version switcher UI elements), but we're catching up on those features. I'll comment more on DM's overall documentation infrastructure roadmap over in LSSTDESC/ComputingInfrastructure#24 |
I should also mention that I haven't tested the Getting doc content into Sphinx is a separate issue as well :) That said, a lot of your content is already reST, so it's a matter of organizing those files and linking them from a |
This is so cool. Thanks Jonathan! We are going to hack on this tomorrow, one way or another - we'll keep you in the loop so you can see what we're up to, but for a start, you could subscribe to #284 :-) |
@jonathansick I went ahead and merged your updates into the issue/251/try_lsst_the_docs branch and the travis build went well it seems: |
Looks like the issue is at line 1267 of the Travis log you linked: |
pip install is available - for fun I moved the |
@jonathansick Returning to your nice PR here - it is a nice pull request but I'm not sure it does what we want yet. The Twinkles repo now contains a set of in-progress DESC Notes, in the |
I think we will need DESC project specific areas in LTD like (twinkles.lsst.io) for Twinkles specific documentation. The DESC notes being cross-project, would more rightly belong in a global DESC web area like desc.lsst.io. Perhaps the travis-ci configuration for each github repo would require the ability to split their documentation across two web-accessible areas. |
Got it, thanks Heather. Your plan sounds good to me! On Fri, Aug 5, 2016 at 11:53 AM, Heather Kelly [email protected]
|
@jonathansick Time to pick your brain! I have continued to play with your updates and have completely dumbed down our travis-ci setup as I am grappling with an "Out of Space" error. I turned off all of our other tests and just set up sphinx and let that bit go. I just want to see that bit work and I'll go back and deal with the space issue. Do you have some ideas what might be going wrong? |
@heather999 It ended up being published to https://twinkles.lsst.io/v/issue-251-try-lsst-the-docs 💥 So it works :) What happened is that the branch you were working with is It does highlight that only branches from the repo in the DarkEnergyScienceCollaboration GitHub org will be published, rather than PRs from forks like mine. It ends up being because of security issues (anyone can submit a PR, but you don't want anyone to necessarily publish to lsst.io). Now maybe there's a way around this we can find if fork-and-PR is central to DESC. DM uses its GitHub repos as shared origins that we push directly to, for example. The out-of-space issues with Travis are a bit more problematic. I can't believe that installing a few extra Python dependencies and building docs is pushing you over the edge on Travis. I don't really have an answer for that yet. I wonder if a self-hosted CI like Jenkins is needed? |
This PR is pursuing #251, following-up on the conversation in https://community.lsst.org/t/introducing-lsst-the-docs-for-continuous-documentation-delivery/781/7?u=jsick.
The PR does two things
doc/
I can't test a full publication workflow up LSST the Docs since this branch needs to be in the DarkEnergyScienceCollaboration/Twinkles repo itself, and not my fork. (Obviously I can't push to Twinkles).
Sorry this project kept slipping in my schedule. I'm not sure whether you want to continue pursuing this, or keep your gh-pages workflow. Likely Sphinx-LTD will work well for code documentation. Over time you may decide to switch the high-level docs you have in gh-pages over to LTD.