Skip to content

Commit

Permalink
Apply black and isort (#18)
Browse files Browse the repository at this point in the history
* Fix README.md badge

* Fix: error of window closing when exception occur (#7)

* Fix ESP delimeter error: add time sleep(0.1)

* Add exception catch hook & Remove comments

* Fix progress bar percent decimals

* Fix version info rstrip

* Add popup window when exception occurred

* Remove print json used for debugging

* Change name of exception hook method & Add icon and error text to popup

* Add detailed text about exception traceback & Resize of window

* Add exit and report button to popup & Rename class and method of popup

* Add popup error message for exceptions in thread

* Change names of methods to show meanings of roles

* Fix convention of long line

* Add popup message for reconnection error & set level of error

* Add popup message of reconnection error

* Change line continuation annotation \ -> ()

* Refactor statement using if else to switch with dict

* Refactor hard coded numbers to constant variables

* Refactor import _thread to _thread._ExceptHookArgs as _th._exc

* Refactor to meet convention tests

* Remove report error button and restart button

* Remove whitespace and comment unused lines to meet the conventions

* Remove blank line to meet the conventions

* Fix _thread._ExceptHookArgs issue

* Remove unused import

* Send packet to turn interpreter off

* Notify user when turning interpreter off

* Remove unused lines

* Temporally comment out restart button

* Update PRT

* Translate issue_templates to Korean

* Change path to STM32 firmwares

* Remove redundant lines in ESP32 Updater

* Use excepthook again to show popup

* Remove unused import in gui_firmware_updater

* Add black code checker and put it in the actions workflow

* Add black check and apply it to the code (#17)

* Add configurations for black and flake8

* Apply formatter black

* Fix flake8 configuration of git actions

* Apply black formatting

* Remove black formatting

* Add isort check and apply it to the code (#16)

Co-authored-by: Jemin Yeon <[email protected]>

Co-authored-by: Jinsung Ha <[email protected]>
  • Loading branch information
yjm07 and 94929 authored Jun 17, 2021
1 parent cd29732 commit 6e65aa2
Show file tree
Hide file tree
Showing 11 changed files with 559 additions and 530 deletions.
2 changes: 2 additions & 0 deletions .flake8
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[flake8]
ignore = E203
16 changes: 12 additions & 4 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,10 @@ jobs:
python -m pytest
- name: Run convention tests
run: |
python -m flake8 modi_firmware_updater tests --ignore E265,W503,W504
python -m flake8 modi_firmware_updater tests --ignore E203,W503,W504
- name: Run import sort check
run: |
python -m isort modi_firmware_updater tests --diff
build-macos:
name: macOS Test
runs-on: macos-latest
Expand All @@ -46,7 +49,10 @@ jobs:
python -m pytest
- name: Run convention tests
run: |
python -m flake8 modi_firmware_updater tests --ignore E265,W503,W504
python -m flake8 modi_firmware_updater tests --ignore E203,W503,W504
- name: Run import sort check
run: |
python -m isort modi_firmware_updater tests --diff
build-windows:
name: Windows Test
runs-on: windows-latest
Expand All @@ -68,5 +74,7 @@ jobs:
python -m pytest
- name: Run convention tests
run: |
python -m flake8 modi_firmware_updater tests --ignore E265,W503,W504
python -m flake8 modi_firmware_updater tests --ignore E203,W503,W504
- name: Run import sort check
run: |
python -m isort modi_firmware_updater tests --diff
Loading

0 comments on commit 6e65aa2

Please sign in to comment.