Regression test for Impersonating Troubleshooter #1697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
labkey-adam
approved these changes
Oct 31, 2023
| @@ -40,11 +42,18 @@ public class AppAdminRoleTest extends BaseWebDriverTest | |||
| { | |||
| private static final String APP_ADMIN = "[email protected]"; | |||
| private static final String USER = "[email protected]"; | |||
| private static final String ADMIN_GROUP = "Custom Admin Group"; | |||
There was a problem hiding this comment.
SITE_ADMIN_GROUP and "Custom Site Admin Group" for clarity?
| public static final String DEVELOPER_ROLE = "Platform Developer"; | ||
| public static final String IMP_TROUBLESHOOTER_ROLE = "Impersonating Troubleshooter"; | ||
|
|
||
| public static String toRole(final String name) |
There was a problem hiding this comment.
Should callers use the above constants to specify common roles instead of hard-coded strings?
|
Just FYI: I have a local change that disables the privileged roles on the permissions page for App Admins, which I think is a better experience. This test will need to be updated when (or before) that's merged. |
labkey-danield
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
The new
ImpersonatingTroubleshooterRoleneeds testing.PermissionsEditorautomatically saves after several operations, which makes it difficult to test error conditions. It isn't widely used however (it duplicates a lot of functionality from the more populareUIPermissionsHelper).Story
Related Pull Requests
Changes
PermissionsEditortest pagePermissionsHelper.getRolesstatic