Skip to content

Fix loading error #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix loading error #10

wants to merge 4 commits into from

Conversation

CrazyH2
Copy link

@CrazyH2 CrazyH2 commented Dec 10, 2023

Fixes loading by using class constructors

@LabyStudio
Copy link
Owner

What kind of error do you get? The TagRegistry is completely static and shouldn't require a constructor

@CrazyH2
Copy link
Author

CrazyH2 commented Jan 26, 2024

What kind of error do you get? The TagRegistry is completely static and shouldn't require a constructor

Safari will return an error if it isn't a constructor.

@LabyStudio
Copy link
Owner

Just tested it on Safari/macOS and Safari/iOS. It works without any issues

@CrazyH2
Copy link
Author

CrazyH2 commented Feb 22, 2024

Screenshot 2024-02-22 at 09 50 35

It gives me this error @LabyStudio

I am on macOS Monterey (12.5)
MacBook Air (M1, 2020)

And when I changed it to a constructor it seemed to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants