LibWeb: Treat import rules as invalid if preceded by non-import rules #3283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtkinsSJ
reviewed
Jan 16, 2025
| auto is_layer_statement_rule = is<CSSLayerStatementRule>(*rule); | ||
| auto is_import_rule = is<CSSImportRule>(*rule); | ||
|
|
||
| // FIXME: Include @charset rules in this check when they are added. |
There was a problem hiding this comment.
This FIXME isn't necessary. It's confusing, but @charset is a weird beast that isn't actually an at-rule that shows up in the CSSOM. https://drafts.csswg.org/css-syntax/#charset-rule
There was a problem hiding this comment.
...there are order-requirements for @namespace though, and I think some others.
github-actions
bot
added
the
conflicts
|
Your pull request has conflicts that need to be resolved before it can be reviewed and merged. Make sure to rebase your branch on top of the latest |
If an import statement is preceded by a valid rule that isn't an import rule or a @layer statement rule, it is now treated as invalid.
tcl3
force-pushed
the
libweb_invalid_import_rules
branch
from
6796836 to
7d9305c
Compare
github-actions
bot
removed
the
conflicts
|
Two thoughts on this:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an import statement is preceded by a valid rule that isn't an import rule or a @layer statement rule, it is now treated as invalid.
Fixes: http://wpt.live/css/CSS2/css1/c11-import-000.xht