LibWeb: Draw floating replaced elements more correctly #3430
+73
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmta
reviewed
Feb 3, 2025
InvalidUsernameException
force-pushed
the
floats-as-own-stacking-context
branch
from
94432f1 to
7a76914
Compare
InvalidUsernameException
force-pushed
the
floats-as-own-stacking-context
branch
4 times, most recently
from
43dbd91 to
4870cf7
Compare
|
Rebased on master to fix CI. |
InvalidUsernameException
force-pushed
the
floats-as-own-stacking-context
branch
from
4870cf7 to
3468fca
Compare
kalenikaliaksandr
requested changes
Feb 16, 2025
| @@ -0,0 +1,27 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
I compared this page on build from master vs other browsers and it seems to visually already be painted correctly. could we add a test that demoes correctness improvement?
There was a problem hiding this comment.
I guess something changed then in the commits on master that I rebased over. It rendered incorrectly on master when I first opened the PR. I'll take a look.
There was a problem hiding this comment.
The test still reproduces the original problem for me as of 29d7463.
| Master | This PR/other browser |
|---|---|
 |
 |
I've rebased on that commit now.
Previously floating replaced elements were drawn incorrectly and also twice.
InvalidUsernameException
force-pushed
the
floats-as-own-stacking-context
branch
from
3468fca to
5265cb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously floating replaced elements were drawn incorrectly and also twice.
This was originally discovered because of the
css/css-images/object-fit-*set of tests from the WPT suite. Those use dashed borders to draw floating replaced elements. The dashed borders use subpixel rendering, so rendering them twice made the borders darker than they were supposed to be. The tests themselves cannot be imported though because a) they either fail for other, unrelated reasons, or b) they only pass because both test and ref page don't render the intended content yet.