Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibWeb: Add Location.ancestorOrigins #3508

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Psychpsyo
Copy link
Contributor

Implements the ancestorOrigins property on Location objects.
Not 100% sure how to properly test this and there's no WPT coverage either, but the feature might also still get changed, as per the spec comment.

@shannonbooth
Copy link
Contributor

shannonbooth commented Feb 8, 2025

I am not sure we should implement this, gecko does not implement this due to privacy concerns (so my opinion is we probably should not). From what I understand this is really only used by ad-tech out on real sites.

@tcl3
Copy link
Member

tcl3 commented Feb 8, 2025

FWIW, there was some previous discussion on #623 about how to implement this API in a way that preserves user privacy.

@Psychpsyo
Copy link
Contributor Author

I am not sure we should implement this, gecko does not implement this due to privacy concerns (so my opinion is we probably should not). From what I understand this is really only used by ad-tech out on real sites.

That makes sense, since I saw the error pop up on Youtube.
I'll convert this to a draft until that gets resolved then since I don't personally care much about this property myself.

@Psychpsyo Psychpsyo marked this pull request as draft February 8, 2025 20:50
@shannonbooth
Copy link
Contributor

It may be worth changing the IDL to not have [FIXME] in it, and instead leave a comment saying that we have chosen not to implement and are waiting for when/if the spec changes to address those concerns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants