Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta: Unbreak the NixOS development shell #738

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

timschumi
Copy link
Member

@timschumi timschumi commented Jul 20, 2024

Currently still fails to find OpenGL libraries (and depends on an uprev to NixOS/nixpkgs#328685), and therefore a draft:

-- Could NOT find OpenGL (missing: OPENGL_opengl_LIBRARY OPENGL_glx_LIBRARY OPENGL_INCLUDE_DIR) 
-- Could NOT find OpenGL (missing: OPENGL_opengl_LIBRARY OPENGL_INCLUDE_DIR OpenGL) 
-- Could NOT find WrapOpenGL (missing: WrapOpenGL_FOUND) 
CMake Warning at Toolchain/Tarballs/vcpkg/scripts/buildsystems/vcpkg.cmake:859 (_find_package):
  Found package configuration file:

    /usr/lib64/cmake/Qt6Gui/Qt6GuiConfig.cmake

  but it set Qt6Gui_FOUND to FALSE so package "Qt6Gui" is considered to be
  NOT FOUND.  Reason given by package:

  Qt6Gui could not be found because dependency WrapOpenGL could not be found.

  Configuring with --debug-find-pkg=WrapOpenGL might reveal details why the
  package was not found.

  Configuring with -DQT_DEBUG_FIND_PACKAGE=ON will print the values of some
  of the path variables that find_package uses to try and find the package.

Call Stack (most recent call first):
  /nix/store/ll2b6cslly4v30im7qk34f9y21ziiz1i-cmake-3.29.6/share/cmake-3.29/Modules/CMakeFindDependencyMacro.cmake:76 (find_package)
  /usr/lib/cmake/Qt6/QtPublicDependencyHelpers.cmake:111 (find_dependency)
  /usr/lib64/cmake/Qt6Widgets/Qt6WidgetsDependencies.cmake:42 (_qt_internal_find_qt_dependencies)
  /usr/lib64/cmake/Qt6Widgets/Qt6WidgetsConfig.cmake:43 (include)
  Toolchain/Tarballs/vcpkg/scripts/buildsystems/vcpkg.cmake:859 (_find_package)
  /usr/lib64/cmake/Qt6/Qt6Config.cmake:169 (find_package)
  Toolchain/Tarballs/vcpkg/scripts/buildsystems/vcpkg.cmake:859 (_find_package)
  CMakeLists.txt:83 (find_package)


CMake Warning at Toolchain/Tarballs/vcpkg/scripts/buildsystems/vcpkg.cmake:859 (_find_package):
  Found package configuration file:

    /usr/lib64/cmake/Qt6Widgets/Qt6WidgetsConfig.cmake

  but it set Qt6Widgets_FOUND to FALSE so package "Qt6Widgets" is considered
  to be NOT FOUND.  Reason given by package:

  Qt6Widgets could not be found because dependency Qt6Gui could not be found.

  Configuring with --debug-find-pkg=Qt6Gui might reveal details why the
  package was not found.

  Configuring with -DQT_DEBUG_FIND_PACKAGE=ON will print the values of some
  of the path variables that find_package uses to try and find the package.

Call Stack (most recent call first):
  /usr/lib64/cmake/Qt6/Qt6Config.cmake:169 (find_package)
  Toolchain/Tarballs/vcpkg/scripts/buildsystems/vcpkg.cmake:859 (_find_package)
  CMakeLists.txt:83 (find_package)


CMake Error at Toolchain/Tarballs/vcpkg/scripts/buildsystems/vcpkg.cmake:859 (_find_package):
  Found package configuration file:

    /usr/lib64/cmake/Qt6/Qt6Config.cmake

  but it set Qt6_FOUND to FALSE so package "Qt6" is considered to be NOT
  FOUND.  Reason given by package:

  Failed to find required Qt component "Widgets".

  Expected Config file at
  "/usr/lib64/cmake/Qt6Widgets/Qt6WidgetsConfig.cmake" exists



  Configuring with --debug-find-pkg=Qt6Widgets might reveal details why the
  package was not found.

  Configuring with -DQT_DEBUG_FIND_PACKAGE=ON will print the values of some
  of the path variables that find_package uses to try and find the package.

Call Stack (most recent call first):
  CMakeLists.txt:83 (find_package)

@ADKaster
Copy link
Member

Given #2450, should we drop this patch?

@timschumi
Copy link
Member Author

My PR is most likely superseded, yes, but I had some issues with FHS creation that I would want to check for before merging the other one.

@timschumi
Copy link
Member Author

timschumi commented Nov 30, 2024

Not superseded, this still attempts to fix vcpkg because that's what ladybird.sh uses. Although I will rebase on the other PR after that one is merged.

@github-actions github-actions bot added the conflicts Pull request has merge conflicts that need resolution label Dec 17, 2024
Copy link

github-actions bot commented Jan 8, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

@github-actions github-actions bot added the stale label Jan 8, 2025
Copy link

This pull request has been closed because it has not had recent activity. Feel free to re-open if you wish to still contribute these changes. Thank you for your contributions!

@github-actions github-actions bot closed this Jan 16, 2025
No, I do not want to query the qt6 stdenv for the host platform.
Due to the nature of nixpkgs lagging behind we will have to maintain our
own package list anyway, so we might as well maintain it entirely.

This also allows us to prune the list occasionally and gives nixpkgs a
baseline for a new package set whenever they bump the package version.
@ADKaster ADKaster reopened this Feb 17, 2025
@github-actions github-actions bot removed the conflicts Pull request has merge conflicts that need resolution label Feb 17, 2025
@ADKaster ADKaster removed the stale label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants