Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some new config options #233

Merged
merged 4 commits into from
Jan 7, 2024
Merged

Some new config options #233

merged 4 commits into from
Jan 7, 2024

Conversation

donkeyrat
Copy link
Contributor

I found some important oversights in the mod's configurability, so I opted to make a pull request that adds them.
The new config options are:

  • splashThreshold: Allows tweaking at what velocity an entity creates a splash.
  • spectralArrowTrails: Replaces improvedSpectralArrows, works just like the Allay trail configuration.
  • freezeFrames: Allows changing how many frames parrying freezes the screen for.

Pyrofab
Pyrofab approved these changes Jan 7, 2024
View reviewed changes
Copy link
Member

@Pyrofab Pyrofab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

It's lacking descriptions for the new options, but I can add them myself

@Pyrofab Pyrofab merged commit 7daae96 into Ladysnake:main Jan 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pyrofab Pyrofab Pyrofab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@donkeyrat @Pyrofab