Skip to content

Commit

Permalink
refa (Laerdal.Builder.targets): disable the explicit call over to _Do…
Browse files Browse the repository at this point in the history
…wnloadIosNativeFiles because now it gets automatically invoked by the build target thanks to the previous fix in the previous commits
  • Loading branch information
ksidirop-laerdal committed May 9, 2024
1 parent fdb804d commit 4a526f9
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Laerdal.Dfu.Bindings.iOS/Laerdal.Dfu.Bindings.iOS.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
Lines="github "NordicSemiconductor/IOS-Pods-DFU-Library" "$(Nordic_Package_Version)""
Overwrite="true"/>

<Exec Command="GITHUB_ACCESS_TOKEN=&quot;github.com=$(Laerdal_Github_Access_Token)&quot; carthage update --project-directory Carthage --use-xcframeworks --platform iOS --no-use-binaries" />
<Exec Command="GITHUB_ACCESS_TOKEN=&quot;github.com=$(Laerdal_Github_Access_Token)&quot; carthage update --project-directory Carthage --use-xcframeworks --platform iOS --no-use-binaries" />

<RemoveDir
Condition="Exists('Carthage\Carthage\Checkouts\IOS-Pods-DFU-Library\Example')"
Expand Down
3 changes: 2 additions & 1 deletion Laerdal.Scripts/Laerdal.Builder.targets
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@

<!-- BUILD -->
<MSBuild Projects="$(Laerdal_Project)" Properties="$(_Laerdal_Build_Parameters)" Targets="Restore"/>
<MSBuild Projects="$(Laerdal_Project)" Properties="$(_Laerdal_Build_Parameters);BuildingProject=true" Targets="_DownloadIosNativeFiles"/>

<!-- <MSBuild Projects="$(Laerdal_Project)" Properties="$(_Laerdal_Build_Parameters);BuildingProject=true" Targets="_DownloadIosNativeFiles"/> -->
<MSBuild Projects="$(Laerdal_Project)" Properties="$(_Laerdal_Build_Parameters);BuildingProject=true" Targets="Build"/>
</Target>

Expand Down

0 comments on commit 4a526f9

Please sign in to comment.