[WIP] fix (need-wait-for-new-gnark): remove the input hash in groth16 inputs #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silathdiir
commented
Sep 26, 2024
| InputHash frontend.Variable `gnark:"inputHash,public"` | ||
| InputHash frontend.Variable `gnark:"inputHash"` |
There was a problem hiding this comment.
I found that I could remove this from the function verifyProof of generated verifier.sol when deleting public.
silathdiir
changed the title
silathdiir
changed the title
delehef
force-pushed
the
main
branch
8 times, most recently
from
d8cf76a to
a9e2b59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We have
3Groth16 inputs for now:0, since we don't really haveinputs.sha256(plonky2_proof) == this_groth16_input.So I think we may remove the
input hash(one Uint256) in groth16 input.