Merge V1 Code #12
Merged
Merge V1 Code #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check for empty object before null check was causing an error
Manual update to segment start and end dates for the new semester, should move this to an API call in the future
Contains feature additions. Removed cab page for now.
Now displays correct logo in browser tabs
Need to build and deploy using python httpServer to allow service worker to be tested. Added npm script for the same
Color of bullets in month view of timetable was incorrect. Needed to modiy css rule and set to var(--primary-color) to match
Needed to set border color for timetable. Modified CSS rules of the calendar api, and set a conditional color using CSS variables and updated dynamically from the TimeTable.js file
Needed to set the border of events to the primary color
Specify opacity in decimals instead of percentages. This preserves the value while running npm run build. For more info: https://stackoverflow.com/questions/58853844/
Slightly decrease spacing of toolbar and add button Remove the all day slot option Let calendar expand if vertical space is available
Use white as active color in mess day picker center Align items in bus list decrease padding in bus list
Theming and Spacing Changes.
|
✔️ Deploy Preview for flamboyant-bhaskara-9275f5 ready! 🔨 Explore the source changes: 9ea1849 🔍 Inspect the deploy log: https://app.netlify.com/sites/flamboyant-bhaskara-9275f5/deploys/61cbedc488f38a0007508723 😎 Browse the preview: https://deploy-preview-12--flamboyant-bhaskara-9275f5.netlify.app/ |
RachitKeertiDas
requested review from
AdaephonBen,
aayush2710,
npalladium,
tanmayr2 and
butter-chicken27
and removed request for
tanmayr2
butter-chicken27
approved these changes
Dec 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Everyone,
We recently acquired the domain iithdashboard.com. The website is currently configured to serve the master branch of this repository.
We believe the team has completed the first development cycle for this PWA, and the app is ready for releasing v1.
We've gone through most of the papercuts and the project seems ready for the first release, barring issue #11. We did experiment with service workers, however, could not get them working as intended yet. Any help with this will be appreciated.
Solving #11 will make the app offline ready, however the app is ready for online usage.
Please review.