[이한솔][Week2] 웹 백엔드 과제 #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KeonHee
reviewed
Jul 21, 2021
| this.name = name; | ||
| this.phone = phone; | ||
| this.companyName = companyName; | ||
| this.createDate = new Date(); |
There was a problem hiding this comment.
생성자가 생성되는 시점에 Date값이 초기화되는 것을 인지해야합니다.
BusinessCard card = new BusinessCard() // 이 시점의 시간이 저장됨| String phone = rs.getString(2); | ||
| String companyName = rs.getString(3); | ||
|
|
||
| BusinessCard businessCard = new BusinessCard(name,phone,companyName); |
There was a problem hiding this comment.
이 시점에 date값이 초기화되기 떄문에 사용자에게 보여질때 생성된 시점이 아니라 호출된 시점의 시간이 보여지겠죠. 또 호출될 때마다 시간이 다르게 보일겁니다.
There was a problem hiding this comment.
그리고 라인 삐뚤빼뚤한거 라인포매팅으로 정리한번 해주세요~
There was a problem hiding this comment.
IDE들에서 라인포매팅을 잘 지원해주고 있어요!
| PreparedStatement ps = conn.prepareStatement(sql)){ | ||
| ps.setString(1, businessCard.getName()); | ||
| ps.setString(2, businessCard.getPhone()); | ||
| ps.setString(3, businessCard.getCompanyName()); |
There was a problem hiding this comment.
Date값이 안들어가 있네요~
DB에 date 관련된 타입의 컬럼 추가 하시고, 값한번 넣어보면서 테스트해보세요
참고: https://blog.naver.com/jihye2340/220633994462
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
과제 내용 요약
어려웠던 점
코드 리뷰 받고 싶은 부분