Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

week 1 #9

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

week 1 #9

wants to merge 2 commits into from

Conversation

JJJoonngg
Copy link
Member

No description provided.

@JJJoonngg JJJoonngg requested a review from ckgod August 4, 2022 12:13
android:layout_width="wrap_content"
android:layout_height="30dp"
android:text="박예선님, 상큼달콤한 여름 스무디를 즐겨보세요"
android:textSize="14sp"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TextView마다 textSize를 어떤애는 sp를 쓰고, 또 다른애는 dp를 쓰는데 sp와 dp의 차이 공부해보면 좋을 것 같아

Comment on lines +12 to +25
<TextView
android:id="@+id/grade"
android:layout_width="120dp"
android:layout_height="30dp"
android:background="@drawable/round"
android:layout_marginTop="20dp"
android:text=" SILVER"
android:textStyle="bold"
android:textSize="16sp"
android:textColor="@color/white"
app:layout_constraintTop_toTopOf="parent"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
/>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<TextView
android:id="@+id/grade"
android:layout_width="120dp"
android:layout_height="30dp"
android:background="@drawable/round"
android:layout_marginTop="20dp"
android:text=" SILVER"
android:textStyle="bold"
android:textSize="16sp"
android:textColor="@color/white"
app:layout_constraintTop_toTopOf="parent"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
/>
<TextView
android:id="@+id/grade"
android:layout_width="120dp"
android:layout_height="30dp"
android:background="@drawable/round"
android:layout_marginTop="20dp"
android:text="SILVER"
android:textStyle="bold"
android:textSize="16sp"
android:textColor="@color/white"
app:layout_constraintTop_toTopOf="parent"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
app:drawableEndCompat="@drawable/barcode_resize"
android:paddingHorizontal="10dp"
android:gravity="center_vertical"
android:includeFontPadding="false"/>

TextView에 이미지 넣는 속성값 있으니까 이거 사용해보는 것도 좋아
" SILVER" 이런거는 마진이나 패딩 사용하기

drawble/barcode_resize

<?xml version="1.0" encoding="utf-8"?>
<layer-list xmlns:android="http://schemas.android.com/apk/res/android">
    <item
        android:drawable="@drawable/barcode"
        android:width="30dp"
        android:height="20dp" />
</layer-list>

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants