Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6주차 과제] 박지현 과제 제출합니다. #10

Open
wants to merge 4 commits into
base: jihyun
Choose a base branch
from

Conversation

jlhyunii
Copy link

No description provided.

Copy link

@genius00hwan genius00hwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 일단 approve 드릴테니까 리뷰 적용해서 다음 과제 진행하세요!!


@PostMapping(value = "/members/new")
public String create(MemberForm form) {
public String create(MemberForm form) { //새로운 회원생성, 회원가입 후 메인 페이지로 리다이렉트
Member member = new Member();
member.setName(form.getName());

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setter를 지양합시다!! 생성자로 충분할거 같아요!!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MemberService 만든김에 멤버 생성, 조회 등을 Service에서 처리해보세요!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants