Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docker run] Exit the container in case of errors #615

Merged
merged 1 commit into from
Oct 18, 2023
Merged

[docker run] Exit the container in case of errors #615

merged 1 commit into from
Oct 18, 2023

Conversation

eolivelli
Copy link
Member

Summary:

  • ensure that we exit the container in case of any errors: during setup and in case of any agent failure
  • reduce some logs
  • ensure that logback configuration is applied

@eolivelli eolivelli mentioned this pull request Oct 18, 2023
Closed
@eolivelli eolivelli added this to the 0.3.0 milestone Oct 18, 2023
@eolivelli eolivelli merged commit 17c7c29 into main Oct 18, 2023
9 checks passed
@eolivelli eolivelli deleted the impl/docker-run-fix branch October 18, 2023 15:49
nicoloboschi
nicoloboschi reviewed Oct 18, 2023
View reviewed changes
Copy link
Member

@nicoloboschi nicoloboschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

benfrank241 pushed a commit to vectorize-io/langstream that referenced this pull request May 2, 2024
@eolivelli
[docker run] Exit the container in case of errors (LangStream#615)
ac55eec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoloboschi nicoloboschi nicoloboschi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@eolivelli @nicoloboschi