Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch all exceptions in agent gRPC observers and fail critically #735

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Catch all exceptions in agent gRPC observers and fail critically #735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 24 additions & 34 deletions ...nts/langstream-agent-grpc/src/main/java/ai/langstream/agents/grpc/GrpcAgentProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,41 +126,31 @@ private StreamObserver<ProcessorResponse> getResponseObserver() {
return new StreamObserver<>() {
@Override
public void onNext(ProcessorResponse response) {
if (response.hasSchema()) {
org.apache.avro.Schema schema =
new org.apache.avro.Schema.Parser()
.parse(response.getSchema().getValue().toStringUtf8());
serverSchemas.put(response.getSchema().getSchemaId(), schema);
try {
if (response.hasSchema()) {
org.apache.avro.Schema schema =
new org.apache.avro.Schema.Parser()
.parse(response.getSchema().getValue().toStringUtf8());
serverSchemas.put(response.getSchema().getSchemaId(), schema);
}
for (ProcessorResult result : response.getResultsList()) {
RecordAndSink recordAndSink = sourceRecords.remove(result.getRecordId());
if (recordAndSink == null) {
throw new IllegalArgumentException(
"Received unknown record id " + result.getRecordId());
} else {
recordAndSink
.sink()
.emit(fromGrpc(recordAndSink.sourceRecord(), result));
}
}
} catch (Exception e) {
agentContext.criticalFailure(
new RuntimeException(
"GrpcAgentProcessor error while processing record: %s"
.formatted(e.getMessage()),
e));
}
response.getResultsList()
.forEach(
result -> {
RecordAndSink recordAndSink =
sourceRecords.remove(result.getRecordId());
if (recordAndSink == null) {
agentContext.criticalFailure(
new RuntimeException(
"Received unknown record id "
+ result.getRecordId()));
} else {
try {
recordAndSink
.sink()
.emit(
fromGrpc(
recordAndSink.sourceRecord(),
result));
} catch (Exception e) {
agentContext.criticalFailure(
new RuntimeException(
"Error while processing record %s: %s"
.formatted(
result.getRecordId(),
e.getMessage()),
e));
}
}
});
}

@Override
Expand Down
9 changes: 8 additions & 1 deletion ...m-agents/langstream-agent-grpc/src/main/java/ai/langstream/agents/grpc/GrpcAgentSink.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,13 @@ private StreamObserver<SinkResponse> getResponseObserver() {
return new StreamObserver<>() {
@Override
public void onNext(SinkResponse response) {
if (!writeHandles.containsKey(response.getRecordId())) {
agentContext.criticalFailure(
new RuntimeException(
"GrpcAgentSink received unknown record id: %s"
.formatted(response.getRecordId())));
return;
}
CompletableFuture<?> handle = writeHandles.get(response.getRecordId());
if (response.hasError()) {
handle.completeExceptionally(new RuntimeException(response.getError()));
Expand Down Expand Up @@ -124,7 +131,7 @@ public void onError(Throwable throwable) {
public void onCompleted() {
if (startFailedButDevelopmentMode || restarting.get()) {
log.info(
"Ignoring server complietion during restart in dev mode, "
"Ignoring server completion during restart in dev mode, "
+ "ignoring records {}",
writeHandles);
writeHandles.forEach((id, handle) -> handle.complete(null));
Expand Down
15 changes: 8 additions & 7 deletions ...agents/langstream-agent-grpc/src/main/java/ai/langstream/agents/grpc/GrpcAgentSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,19 +105,20 @@ private StreamObserver<SourceResponse> getResponseObserver() {
return new StreamObserver<>() {
@Override
public void onNext(SourceResponse response) {
if (response.hasSchema()) {
org.apache.avro.Schema schema =
new org.apache.avro.Schema.Parser()
.parse(response.getSchema().getValue().toStringUtf8());
serverSchemas.put(response.getSchema().getSchemaId(), schema);
}
try {
if (response.hasSchema()) {
org.apache.avro.Schema schema =
new org.apache.avro.Schema.Parser()
.parse(response.getSchema().getValue().toStringUtf8());
serverSchemas.put(response.getSchema().getSchemaId(), schema);
}

for (ai.langstream.agents.grpc.Record record : response.getRecordsList()) {
readRecords.add(fromGrpc(record));
}
} catch (Exception e) {
agentContext.criticalFailure(
new RuntimeException("Error while processing records", e));
new RuntimeException("GrpcAgentSource error while reading records", e));
}
}

Expand Down
4 changes: 2 additions & 2 deletions ...langstream-agent-grpc/src/test/java/ai/langstream/agents/grpc/GrpcAgentProcessorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,8 +227,8 @@ void testFailingRecord() throws Exception {
@CsvSource({
"failing-server,gRPC server sent error: INTERNAL: server error",
"completing-server,gRPC server completed the stream unexpectedly",
"wrong-record-id,Received unknown record id 2",
"wrong-schema-id,Error while processing record 1: Unknown schema id 1"
"wrong-record-id,GrpcAgentProcessor error while processing record: Received unknown record id 2",
"wrong-schema-id,GrpcAgentProcessor error while processing record: Unknown schema id 1"
})
void testServerError(String origin, String error) throws Exception {
Record inputRecord = SimpleRecord.builder().origin(origin).build();
Expand Down
Loading