Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resource leak in gateway when using Pulsar #762

Merged
merged 5 commits into from
May 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ public class ConsumeGateway implements AutoCloseable {
private final TopicConnectionsRuntimeRegistry topicConnectionsRuntimeRegistry;
private final ClusterRuntimeRegistry clusterRuntimeRegistry;

private volatile TopicConnectionsRuntime topicConnectionsRuntime;

private volatile TopicReader reader;
private volatile boolean interrupted;
private volatile String logRef;
Expand Down Expand Up @@ -84,7 +86,7 @@ public void setup(

final StreamingCluster streamingCluster =
requestContext.application().getInstance().streamingCluster();
final TopicConnectionsRuntime topicConnectionsRuntime =
topicConnectionsRuntime =
topicConnectionsRuntimeRegistry
.getTopicConnectionsRuntime(streamingCluster)
.asTopicConnectionsRuntime();
Expand Down Expand Up @@ -203,6 +205,13 @@ private void closeReader() {
log.warn("error closing reader", e);
}
}
if (topicConnectionsRuntime != null) {
try {
topicConnectionsRuntime.close();
} catch (Exception e) {
log.warn("error closing runtime", e);
}
}
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import ai.langstream.api.model.StreamingCluster;
import ai.langstream.api.model.TopicDefinition;
import ai.langstream.api.runner.code.Header;
import ai.langstream.api.runner.code.Record;
import ai.langstream.api.runner.code.SimpleRecord;
import ai.langstream.api.runner.topics.TopicConnectionsRuntime;
import ai.langstream.api.runner.topics.TopicConnectionsRuntimeRegistry;
Expand All @@ -37,7 +38,9 @@
import java.util.List;
import java.util.Map;
import java.util.Set;
import java.util.concurrent.CompletableFuture;
import java.util.stream.Collectors;
import lombok.AllArgsConstructor;
import lombok.Getter;
import lombok.extern.slf4j.Slf4j;
import org.apache.commons.lang3.tuple.Pair;
Expand Down Expand Up @@ -143,6 +146,43 @@ public void start(
key, () -> setupProducer(resolvedTopicName, streamingCluster));
}

@AllArgsConstructor
static class TopicProducerAndRuntime implements TopicProducer {
private TopicProducer producer;
private TopicConnectionsRuntime runtime;

@Override
public void start() {
producer.start();
}

@Override
public void close() {
producer.close();
runtime.close();
}

@Override
public CompletableFuture<?> write(Record record) {
return producer.write(record);
}

@Override
public Object getNativeProducer() {
return producer.getNativeProducer();
}

@Override
public Object getInfo() {
return producer.getInfo();
}

@Override
public long getTotalIn() {
return producer.getTotalIn();
}
}

protected TopicProducer setupProducer(String topic, StreamingCluster streamingCluster) {

final TopicConnectionsRuntime topicConnectionsRuntime =
Expand All @@ -157,7 +197,7 @@ protected TopicProducer setupProducer(String topic, StreamingCluster streamingCl
null, streamingCluster, Map.of("topic", topic));
topicProducer.start();
log.debug("[{}] Started producer on topic {}", logRef, topic);
return topicProducer;
return new TopicProducerAndRuntime(topicProducer, topicConnectionsRuntime);
}

public void produceMessage(String payload) throws ProduceException {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,6 @@ void testSimpleProduce() throws Exception {
final String url =
"http://localhost:%d/api/gateways/produce/tenant1/application1/produce"
.formatted(port);

produceJsonAndExpectOk(url, "{\"key\": \"my-key\", \"value\": \"my-value\"}");
produceJsonAndExpectOk(url, "{\"key\": \"my-key\"}");
produceJsonAndExpectOk(url, "{\"key\": \"my-key\", \"headers\": {\"h1\": \"v1\"}}");
Expand Down Expand Up @@ -569,6 +568,27 @@ void testService() throws Exception {
produceJsonAndGetBody(
url,
"{\"key\": \"my-key2\", \"value\": \"my-value\", \"headers\": {\"header1\":\"value1\"}}"));

// sorry but kafka can't keep up
final int numParallel = getStreamingCluster().type().equals("kafka") ? 5 : 30;

List<CompletableFuture<Void>> futures1 = new ArrayList<>();
for (int i = 0; i < numParallel; i++) {
CompletableFuture<Void> future =
CompletableFuture.runAsync(
() -> {
for (int j = 0; j < 10; j++) {
assertMessageContent(
new MsgRecord("my-key", "my-value", Map.of()),
produceJsonAndGetBody(
url,
"{\"key\": \"my-key\", \"value\": \"my-value\"}"));
}
});
futures1.add(future);
}
CompletableFuture.allOf(futures1.toArray(new CompletableFuture[] {}))
.get(2, TimeUnit.MINUTES);
}

private void startTopicExchange(String logicalFromTopic, String logicalToTopic)
Expand Down
Loading