Skip to content

Commit

Permalink
qa fixes?
Browse files Browse the repository at this point in the history
  • Loading branch information
LaravelFreelancerNL committed Nov 27, 2023
1 parent 740b033 commit f2a08fd
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
7 changes: 4 additions & 3 deletions bin/qa.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,10 @@ echo "Fix coding style"
echo "Run PHPMD"
./vendor/bin/phpmd src/ text phpmd-ruleset.xml

echo "Test package from within phpunit"
./vendor/bin/testbench migrate:fresh --path=tests/Setup/Database/Migrations --realpath --seed
./vendor/bin/testbench package:test

echo "Run PHPStan"
./vendor/bin/phpstan analyse -c phpstan.neon

echo "Test package from within phpunit"
./vendor/bin/testbench migrate:fresh --path=tests/Setup/Database/Migrations --realpath --seed --seeder=Tests\\Setup\\Database\\Seeds\\DatabaseSeeder
./vendor/bin/testbench package:test
3 changes: 1 addition & 2 deletions src/Query/Concerns/CompilesColumns.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
use Illuminate\Database\Query\Builder as IlluminateQueryBuilder;
use Illuminate\Database\Query\Expression;
use LaravelFreelancerNL\Aranguent\Query\Builder;
use LaravelFreelancerNL\FluentAQL\QueryBuilder;

trait CompilesColumns
{
Expand Down Expand Up @@ -76,7 +75,7 @@ protected function normalizeColumn(IlluminateQueryBuilder $query, mixed $column,
{
assert($query instanceof Builder);

if ( $column instanceof Expression) {
if ($column instanceof Expression) {
return $column;
}

Expand Down

0 comments on commit f2a08fd

Please sign in to comment.