Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add error if LaserficheSignIn page is not configured #58

Merged
merged 7 commits into from
Oct 18, 2023
Merged

add error if LaserficheSignIn page is not configured #58

merged 7 commits into from
Oct 18, 2023

Conversation

alexgomezlf
Copy link
Collaborator

No description provided.

rfulton-lf
rfulton-lf reviewed Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@rfulton-lf rfulton-lf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(1) can we pull the needLaserficheSignInPage constant into constants.ts
(2) If the catch block should be empty, let's remove the TODO, otherwise, let's handle the error

src/webparts/LaserficheRepositoryAccessWebPart/components/LaserficheRepositoryAccessWebPart.tsx Show resolved Hide resolved
src/webparts/laserficheAdminConfiguration/components/LaserficheAdminConfiguration.tsx Show resolved Hide resolved
src/webparts/sendToLaserficheLoginComponent/components/SendToLaserficheLoginComponent.tsx Outdated Show resolved Hide resolved
src/webparts/sendToLaserficheLoginComponent/components/SendToLaserficheLoginComponent.tsx Show resolved Hide resolved
src/webparts/laserficheAdminConfiguration/components/LaserficheAdminConfiguration.tsx Show resolved Hide resolved
src/webparts/LaserficheRepositoryAccessWebPart/components/LaserficheRepositoryAccessWebPart.tsx Show resolved Hide resolved
@alexgomezlf alexgomezlf merged commit 75a684e into 1.x Oct 18, 2023
3 checks passed
@alexgomezlf alexgomezlf deleted the alex/good-erro-for-signin-page branch October 18, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfulton-lf rfulton-lf rfulton-lf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexgomezlf @rfulton-lf