Skip to content
This repository has been archived by the owner on Apr 20, 2021. It is now read-only.

[WIP] [BigInt] Add impl & tests #79

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

nrryuya
Copy link
Member

@nrryuya nrryuya commented Jan 22, 2019

code size reduction

For code size reduction, I inlined these functions in the previous code,

  • _convertUInt256ListToBytes
  • _convertBytesArrayToUInt256List
  • _compare

following the changes made in #72 from the first commit to the third commit.

What's next?

  • Add isPrime.vy (Initial PR #74)
  • Fix RSAAccumulator.vy to use this and isPrime.vy

Others

  • Should we divide the result of modularMul4 and modularMulBy4 by 4?
  • Is it more efficient (in gas or code size) to do arithmetic in bytes[256] (without converting them to uint256[8]?) like other implementations?

This was referenced Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant