fix OFT and OFTV2 deployment code and corresponding README.md instruc… #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions The instructions for deploying OFTV2 in README.md did not work, as the deployment scripts refer to ExampleOFT and ExampleOFTV2 contracts, which don't exist. I changed these to OFTMock and OFTV2Mock respectively. Additionally, instructions failed to mention that the deployer *must* set a minDstGasLimit in this version of code. I added this instruction in and was able to send tokens successfully. Lastly, even though there is not an example for OFT, we failed to include a task to mintTokens(...). This PR includes a small task to mint tokens so the OFT example can be tested. Signed-off-by: Ryan Goulding <[email protected]>
TRileySchwarz
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tions
The instructions for deploying OFTV2 in README.md did not work, as the deployment scripts refer to ExampleOFT and ExampleOFTV2 contracts, which don't exist. I changed these to OFTMock and OFTV2Mock respectively. Additionally, instructions failed to mention that the deployer must set a minDstGasLimit in this version of code. I added this instruction in and was able to send tokens successfully.
Lastly, even though there is not an example for OFT, we failed to include a task to mintTokens(...). This PR includes a small task to mint tokens so the OFT example can be tested.