Add fuzz tests #137
Merged
Add fuzz tests #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Samuel Laferriere <[email protected]>
epociask
reviewed
Sep 24, 2024
|
@anupsv why did we never merge this? Do you want to rebase so we can merge? Hopefully its not too gnarly |
That's a good question. Idk why we didn't merge it. I'll rebase and merge. |
samlaf
reviewed
Dec 19, 2024
samlaf
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
LGTM. Haven't actually read through the tests but let's just merge and if they are flaky we can deal with them later. Better to have more protection than less.
Things to look for in the future:
- don't think we need the
FUZZ=trueenv var, go fuzzer (https://pkg.go.dev/testing) seems to only run fuzz testing when you add the -fuzz - 15m seems a bit long if our other tests run in <10 mins. We might want to bring this down.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Fixes #
Changes proposed
Screenshots (Optional)
Note to reviewers