Skip to content

Feat: generate parameters for checkSignatures by referencing OperatorStateRetriever on-chain #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 34 commits into
base: dev
Choose a base branch
from
Open

Feat: generate parameters for checkSignatures by referencing OperatorStateRetriever on-chain #455

wants to merge 34 commits into from
+2,103 −0

Conversation

rubydusa
Copy link

@rubydusa rubydusa commented Apr 6, 2025

Motivation:

Computation of the parameters needed for signature verification is typically done through the Eigen go or rust services. However, the rust services are not reliable at the current moment and some projects might want to have signature verifications without having to rely on these services.

This PR aims to make the computation of the NonSignerStakesAndSignature parameter easier and accessible through implementing it in OperatorStateRetriever contract

Modifications:

  • added getNonSignerStakesAndSignature to OperatorStateRetriever
  • added BN256G2 solidity library dependency

Result:

Computing the data necessary for performing signature verification is more accessible

rubydusa and others added 26 commits March 11, 2025 16:05
@rubydusa
feat: getNonSignerStakesAndSignature
d4fff29
@rubydusa
chore: add BN256G2
f1186b6
@rubydusa
refactor: BN256G2 ^0.4.24 -> ^0.8.27
55ef0ed
@rubydusa
fix: compute g2 apk
595b824
@hudsonhrh
test: inital test of getNonSignerStakesAndSignature
b322318
@hudsonhrh
test: getNonSignerStakesAndSignature tests now use real G2 points
d050b75
@hudsonhrh
test: added tests for diffferent revert scenariois
cd0de93
@rubydusa
fix: _makeG2Point comments
89aac24
@rubydusa
chore: use G2 coordinates from BN254
f65636d
@rubydusa
fix: compute quorum APKs by timestamp
1bb0c3f
@rubydusa
refactor: safe gaurd against invalid sigmas
22b355a
@rubydusa
test: getNonSignerStakesAndSignature changing Quorum set
22810cd
@rubydusa
fix: convert blockNumber to uint32
973e278
@rubydusa
chore: clarify operatorIds -> signingOperatorIds
2d7c073
@rubydusa
Merge branch 'latest-dev' into on-chain-check-signatures
f310f09
@rubydusa
chore: delete non-sensical no signers test
76ffef7
@rubydusa
chore: add natspec to new functions in OperatorStateRetriever
e758ffa
@bagelface
docs: fix capitalization of comments and natspec for getNonSignerStak…
021d32c 
…esAndSignature
@hudsonhrh
revert comment changes
a294309
Update isOnCurve function as pure
e0bd81f
@diterra-code
docs: fix "getNonSignerStakesAndSignature" natspec comment
c3e1ba1
@cathschmidt
fix: formatting
4f6b395
@Astodialo
fix: clean up
beffb0b
@rubydusa
Merge branch 'dev' of https://github.com/Layr-Labs/eigenlayer-middleware
59a4b02 
 into on-chain-check-signatures
@rubydusa
fix: type in _computeG1APK natspec
463166c
@rubydusa
fix: incorrect curve equation in doc comment
0530e77
@RonTuretzky RonTuretzky mentioned this pull request Apr 7, 2025
Open
MegaRedHand
MegaRedHand reviewed Apr 10, 2025
View reviewed changes
@MegaRedHand
Copy link

CI's failing due to formatting: https://github.com/Layr-Labs/eigenlayer-middleware/actions/runs/14387747950/job/40347432364?pr=455

@rubydusa
Copy link
Author

There is invalid rpc url error in the CI which I can also see happens on latest commit of dev: https://github.com/Layr-Labs/eigenlayer-middleware/actions/runs/14312178100/job/40109659601#step:5:883

However this PR has 2 failing CI checks and the latest commit in dev only has 1, so I'm not sure if these are just simply different workflows or am I missing something

@MegaRedHand
Copy link

The CI errors in this PR are due to external contributors not having access to repository secrets. I'm not sure about the failure in the latest dev commit, but it seems to be due to something similar. You can run the tests locally with:

HOLESKY_RPC_URL=<some-public-rpc> forge test -vvv
FOUNDRY_PROFILE=forktest forge test --match-contract Integration -vvv

ypatil12
ypatil12 reviewed Apr 22, 2025
View reviewed changes
Copy link
Contributor

@ypatil12 ypatil12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass, minor comment

src/libraries/BN256G2.sol Outdated
@@ -0,0 +1,339 @@
// SPDX-License-Identifier: BUSL-1.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switch out for audited version

ypatil12
ypatil12 requested changes Apr 22, 2025
View reviewed changes
Copy link
Contributor

@ypatil12 ypatil12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the OperatorStateRetriever is already in audit, let's inherit from that and create an unaudited version with this code

@RonTuretzky
refactor: moving lib
3cf04f3 
refactor: import path

refactor: rename

format: forge fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MegaRedHand MegaRedHand MegaRedHand left review comments

@tsnewnami tsnewnami tsnewnami left review comments

@ypatil12 ypatil12 ypatil12 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@rubydusa @MegaRedHand @ypatil12 @tsnewnami @hudsonhrh @bagelface @diterra-code @cathschmidt @Astodialo @RonTuretzky