blsagg: use defer for unlock

Layr-Labs · Jun 21, 2024 · 2d89859 · 2d89859
1 parent 6ec28a8
commit 2d89859
Showing 1 changed file with 4 additions and 7 deletions.
diff --git a/services/bls_aggregation/blsagg.go b/services/bls_aggregation/blsagg.go
@@ -174,15 +174,12 @@ func (a *BlsAggregatorService) InitializeNewTask(
 	a.logger.Debug("AggregatorService initializing new task", "taskIndex", taskIndex, "taskCreatedBlock", taskCreatedBlock, "quorumNumbers", quorumNumbers, "quorumThresholdPercentages", quorumThresholdPercentages, "timeToExpiry", timeToExpiry)
 
 	a.taskChansMutex.Lock()
-	signedTaskRespsC, taskExists := a.signedTaskRespsCs[taskIndex]
-	if !taskExists {
-		signedTaskRespsC = make(chan types.SignedTaskResponseDigest)
-		a.signedTaskRespsCs[taskIndex] = signedTaskRespsC
-	}
-	a.taskChansMutex.Unlock()
-	if taskExists {
+	defer a.taskChansMutex.Unlock()
+	if _, taskExists := a.signedTaskRespsCs[taskIndex]; taskExists {
 		return TaskAlreadyInitializedErrorFn(taskIndex)
 	}
+	signedTaskRespsC := make(chan types.SignedTaskResponseDigest)
+	a.signedTaskRespsCs[taskIndex] = signedTaskRespsC
 
 	go a.singleTaskAggregatorGoroutineFunc(taskIndex, taskCreatedBlock, quorumNumbers, quorumThresholdPercentages, timeToExpiry, signedTaskRespsC)
 	return nil