fix: race condition on blsagg

Layr-Labs · Jun 19, 2024 · 8412f23 · 8412f23
1 parent d74457d
commit 8412f23
Showing 1 changed file with 10 additions and 5 deletions.
diff --git a/services/bls_aggregation/blsagg.go b/services/bls_aggregation/blsagg.go
@@ -172,13 +172,18 @@ func (a *BlsAggregatorService) InitializeNewTask(
 	timeToExpiry time.Duration,
 ) error {
 	a.logger.Debug("AggregatorService initializing new task", "taskIndex", taskIndex, "taskCreatedBlock", taskCreatedBlock, "quorumNumbers", quorumNumbers, "quorumThresholdPercentages", quorumThresholdPercentages, "timeToExpiry", timeToExpiry)
-	if _, taskExists := a.signedTaskRespsCs[taskIndex]; taskExists {
-		return TaskAlreadyInitializedErrorFn(taskIndex)
-	}
-	signedTaskRespsC := make(chan types.SignedTaskResponseDigest)
+
 	a.taskChansMutex.Lock()
-	a.signedTaskRespsCs[taskIndex] = signedTaskRespsC
+	signedTaskRespsC, taskExists := a.signedTaskRespsCs[taskIndex]
+	if !taskExists {
+		signedTaskRespsC = make(chan types.SignedTaskResponseDigest)
+		a.signedTaskRespsCs[taskIndex] = signedTaskRespsC
+	}
 	a.taskChansMutex.Unlock()
+	if taskExists {
+		return TaskAlreadyInitializedErrorFn(taskIndex)
+	}
+
 	go a.singleTaskAggregatorGoroutineFunc(taskIndex, taskCreatedBlock, quorumNumbers, quorumThresholdPercentages, timeToExpiry, signedTaskRespsC)
 	return nil
 }