Oprs info parallel query #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| panic(err) | ||
| wg.Wait() | ||
| if pubkeysErr != nil { | ||
| return errors.Join(errors.New("error querying existing registered operators"), pubkeysErr) |
There was a problem hiding this comment.
we have a wrapErr function in utils now right? should use that
There was a problem hiding this comment.
side note: actually don't like utils.wrapErr, wish it was in an errors module, so that we would do errors.wrapErr instead. we could import the sdk errors module as sdkerrors.wrapErr or something
fix operatorsinfo and rebuild mocks fix bug make operators-info query logs in parallel fix lint issue
samlaf
force-pushed
the
oprs-info-parallel-query
branch
from
33a8b18 to
9320da8
Compare
shrimalmadhur
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
created on top of #238 so should merge that first, which will simplify this PR.
What Changed?
Reviewer Checklist