move builders to it's own package #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samlaf
reviewed
Jul 2, 2024
shrimalmadhur
commented
Jul 2, 2024
shrimalmadhur
force-pushed
the
madhur/separate-builders
branch
from
5cc7ba3 to
47bcb7c
Compare
samlaf
reviewed
Jul 3, 2024
Comment on lines
+47
to
+54
| elChainReader, err := elcontracts.NewReaderFromConfig( | ||
| elcontracts.Config{ | ||
| DelegationManagerAddress: avsBindings.DelegationManagerAddr, | ||
| AvsDirectoryAddress: avsBindings.AvsDirectoryAddr, | ||
| }, | ||
| client, | ||
| logger, | ||
| ) |
There was a problem hiding this comment.
do we really need this to be created outside and passed via dependency injection? Or could we just build it inside the NewChainWriter constructor?
There was a problem hiding this comment.
hmm good ques. idk. need to think more
samlaf
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
What Changed?
Reviewer Checklist