refactored elcontracts and avsregistry builders to use wire dependency injection #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,8 +13,9 @@ help: | |||
| bindings: ## generates contract bindings | |||
| cd contracts && rm -rf bindings/* && ./generate-bindings.sh | |||
|
|
|||
| mocks: ## generates mocks | |||
| generate: ## generates mocks and wire files | |||
There was a problem hiding this comment.
why do we need to couple these 2 generation? any particular reason or just to combine generation together?
There was a problem hiding this comment.
Is there a way to separate go generated stuff? Right now if we run go generate it just looks for all the go:generate comments in the repo and executed all of them. Maybe there’s a way to tag the generate commands with subtask names and get go generate to filter on those?
|
Closing as no longer needed. Feels like not enough leverage for the kind of work/refactor needed to push this across the codebase right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/google/wire/tree/main
Overall thinking this could greatly simplify some of our code.
So far I've only refactored basic code to use this, so it feels useless.
But it will start paying off once we use it to update the chainio/clients/builder.go. That way we'll be able to add a bunch of different constructors, all automatically generated, for different use cases:
What Changed?
Reviewer Checklist