Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update: eigensdk bindings for operator set #305

Merged
merged 5 commits into from
Aug 6, 2024
Merged

update: eigensdk bindings for operator set #305

merged 5 commits into from
Aug 6, 2024

Conversation

shrimalmadhur
Copy link
Collaborator

Fixes # .

What Changed?

  • Op set bindings

Reviewer Checklist

  • Code is well-documented
  • Code adheres to Go naming conventions
  • Code deprecates any old functionality before removing it

@shrimalmadhur shrimalmadhur marked this pull request as draft July 23, 2024 01:06
@shrimalmadhur shrimalmadhur force-pushed the madhur-elo-210-add-operatorset-bindings-to-sdk branch from 94bf494 to 32bad91 Compare August 5, 2024 23:30
@shrimalmadhur shrimalmadhur marked this pull request as ready for review August 5, 2024 23:48
@shrimalmadhur shrimalmadhur requested a review from samlaf August 6, 2024 00:43
@samlaf
Copy link
Collaborator

samlaf commented Aug 6, 2024

@shrimalmadhur is "opset" the terminology used in our contracts and/or docs? If not, let's use the full name so as not to confuse anyone else reading these.

samlaf
samlaf approved these changes Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@samlaf samlaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The weird abigen errors we should eventually investigate but let's go with the sleeps for now

@shrimalmadhur shrimalmadhur changed the title update: eigensdk bindings to opset update: eigensdk bindings to operator set Aug 6, 2024
@shrimalmadhur shrimalmadhur changed the title update: eigensdk bindings to operator set update: eigensdk bindings for operator set Aug 6, 2024
@shrimalmadhur shrimalmadhur merged commit 66c0054 into dev Aug 6, 2024
4 checks passed
@shrimalmadhur shrimalmadhur deleted the madhur-elo-210-add-operatorset-bindings-to-sdk branch August 6, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samlaf samlaf samlaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shrimalmadhur @samlaf