feat: check quorums registered detail #331
Conversation
| return nil, err | ||
| } | ||
| numBits := value.BitLen() | ||
| quorums := make([]bool, numBits) |
There was a problem hiding this comment.
How are you using this quorums array? Wouldn't you rather have a map instead?
There was a problem hiding this comment.
Hi, initially i thought we could use index of the array as the quorum index, but yes i have changed it to use a map for more easier to understand
There was a problem hiding this comment.
Think you should only be inputting the non zero quorums into the map? Aka treating it as a set instead of a map. That way you would iterate only on quorums that are nonzero.
There was a problem hiding this comment.
I think it is better to show zero quorums as well? so one use this function can easily get:
- which quorum(s) the operator is in already
- which quorum(s) the operator is not in
so he can adjust the strategy accordingly, i.e. re-join the missing quorum again
There was a problem hiding this comment.
I see. In that case don’t think map is needed and we can revert to array then haha?
There was a problem hiding this comment.
reverted to use array
Add a function to query bitmap of quorums and convert it into human-readable format which is boolean array.
What Changed?
Reviewer Checklist