Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compliance tests #337

Merged
merged 14 commits into from
Sep 12, 2024
Merged

Compliance tests #337

merged 14 commits into from
Sep 12, 2024

Conversation

TomasArrachea
Copy link
Contributor

@TomasArrachea TomasArrachea commented Sep 9, 2024

What Changed?

This PR works on compliance tests to compare sdk status agains other implementations (like rust-sdk)

Modified 2 tests (TestAvsRegistryServiceChainCaller_GetOperatorsAvsState and TestIntegrationBlsAgg) to read the input from a JSON file in the case that the TEST_DATA_PATH env variable is set.

Reviewer Checklist

  • Code is well-documented
  • Code adheres to Go naming conventions
  • Code deprecates any old functionality before removing it

@TomasArrachea TomasArrachea marked this pull request as ready for review September 11, 2024 16:12
Copy link
Collaborator

@shrimalmadhur shrimalmadhur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is it ready to be merged?

@TomasArrachea
Copy link
Contributor Author

LGTM. Is it ready to be merged?

@shrimalmadhur Yes!

@TomasArrachea TomasArrachea merged commit 1b92e0f into Layr-Labs:dev Sep 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants