Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rpc request duration in seconds #338

Merged
merged 1 commit into from
Sep 24, 2024
Merged

fix: rpc request duration in seconds #338

merged 1 commit into from
Sep 24, 2024

Conversation

renlulu
Copy link
Contributor

@renlulu renlulu commented Sep 13, 2024 •
edited
Loading

Fixes #333 .

What Changed?

Reviewer Checklist

  • Code is well-documented
  • Code adheres to Go naming conventions
  • Code deprecates any old functionality before removing it

samlaf
samlaf approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@samlaf samlaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@samlaf samlaf force-pushed the fix/rpc-calls-seconds branch from 4e4ba6d to ed7d114 Compare September 24, 2024 03:28
@samlaf samlaf merged commit c26f5df into Layr-Labs:dev Sep 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samlaf samlaf samlaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The eigen_rpc_request_duration_seconds need change _seconds suffix of the metric name
2 participants
@renlulu @samlaf