Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent Duplicate Signature Processing in BLS Aggregator #345

Merged
merged 8 commits into from
Sep 24, 2024
Merged

Prevent Duplicate Signature Processing in BLS Aggregator #345

merged 8 commits into from
Sep 24, 2024

Conversation

afkbyte
Copy link
Contributor

@afkbyte afkbyte commented Sep 23, 2024 •
edited
Loading

Fixes AVS-1053

What Changed?

Modified singleTaskAggregatorGoroutineFunc in blsagg/bls_aggregator_service.go

  • Added explicit duplicate signature check before signature verification
  • Moved task response hashing earlier in the processing flow
  • Added unit test

Reviewer Checklist

  • Code is well-documented
  • Code adheres to Go naming conventions
  • Code deprecates any old functionality before removing it

samlaf
samlaf reviewed Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@samlaf samlaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! Few nits to make the code more easily readable

services/bls_aggregation/blsagg.go Outdated Show resolved Hide resolved
services/bls_aggregation/blsagg.go Show resolved Hide resolved
services/bls_aggregation/blsagg.go Show resolved Hide resolved
@afkbyte afkbyte force-pushed the afkbyte-avs-1053-avs-devex-prevent-duplicate-signature-processing-in-bls branch from fb2628d to 21635ca Compare September 24, 2024 16:01
@afkbyte afkbyte requested a review from samlaf September 24, 2024 16:27
samlaf
samlaf approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@samlaf samlaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks! operator unit test is failing, we know why. Will push a fix soon and then you'll just have to rebase on top before merging this PR.

@samlaf samlaf merged commit 773903b into dev Sep 24, 2024
4 checks passed
@samlaf samlaf deleted the afkbyte-avs-1053-avs-devex-prevent-duplicate-signature-processing-in-bls branch September 24, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samlaf samlaf samlaf approved these changes

@MegaRedHand MegaRedHand Awaiting requested review from MegaRedHand

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@afkbyte @samlaf @MegaRedHand