Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaning file path before using it #353

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Cleaning file path before using it #353

merged 1 commit into from
Oct 2, 2024

Conversation

pablodeymo
Copy link
Contributor

What Changed?

Before using the path variables, this PR calls filepath.Clean on it to prevent:
G304 (CWE-22): Potential file inclusion via variable

Reviewer Checklist

  • Code is well-documented
  • Code adheres to Go naming conventions
  • Code deprecates any old functionality before removing it

@pablodeymo pablodeymo requested a review from afkbyte October 2, 2024 15:40
@shrimalmadhur shrimalmadhur added this pull request to the merge queue Oct 2, 2024
Merged via the queue into dev with commit b8088bd Oct 2, 2024
4 checks passed
@shrimalmadhur shrimalmadhur deleted the fix_clean_path branch October 2, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanbono juanbono juanbono approved these changes

@shrimalmadhur shrimalmadhur shrimalmadhur approved these changes

@afkbyte afkbyte Awaiting requested review from afkbyte

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pablodeymo @shrimalmadhur @juanbono