Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove panic in BuildAll #354

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Remove panic in BuildAll #354

merged 1 commit into from
Oct 2, 2024

Conversation

pablodeymo
Copy link
Contributor

I think it's better to return an err instead of panicking in BuildAll in chainio/clients/builder.go.

What Changed?

Reviewer Checklist

  • Code is well-documented
  • Code adheres to Go naming conventions
  • Code deprecates any old functionality before removing it

@pablodeymo pablodeymo requested a review from afkbyte October 2, 2024 15:40
@afkbyte afkbyte added this pull request to the merge queue Oct 2, 2024
Merged via the queue into dev with commit bce0284 Oct 2, 2024
4 checks passed
@afkbyte afkbyte deleted the replace_panic branch October 2, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afkbyte afkbyte afkbyte approved these changes

@juanbono juanbono juanbono approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pablodeymo @juanbono @afkbyte