Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ElContracts Writer tests #361

Merged
merged 21 commits into from
Nov 13, 2024
Merged

Add ElContracts Writer tests #361

merged 21 commits into from
Nov 13, 2024

Conversation

pablodeymo
Copy link
Contributor

@pablodeymo pablodeymo commented Sep 27, 2024

What Changed?

  • Added tests for ElContracts Writer
  • Moved BuildTestClients function into a new testutils subpackage

Reviewer Checklist

  • Code is well-documented
  • Code adheres to Go naming conventions
  • Code deprecates any old functionality before removing it

@TomasArrachea TomasArrachea changed the title [WIP] Skeleton for tests in elcontracts writer Add ElContracts Writer tests Oct 2, 2024
@TomasArrachea TomasArrachea marked this pull request as ready for review October 2, 2024 19:00
@TomasArrachea TomasArrachea requested a review from afkbyte October 2, 2024 19:00
chainio/clients/builder.go Outdated Show resolved Hide resolved
@afkbyte
Copy link
Contributor

afkbyte commented Oct 4, 2024

Let's bring in the changes from #360 then looks good to merge to me!

@TomasArrachea
Copy link
Contributor

Let's bring in the changes from #360 then looks good to merge to me!

@afkbyte Done!

@pablodeymo pablodeymo added the maintenance version next maintenance version label Oct 14, 2024
@pablodeymo pablodeymo requested a review from afkbyte October 18, 2024 14:56
Copy link
Contributor

@afkbyte afkbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@afkbyte afkbyte added this pull request to the merge queue Nov 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 13, 2024
@TomasArrachea TomasArrachea added this pull request to the merge queue Nov 13, 2024
Merged via the queue into dev with commit e050883 Nov 13, 2024
4 checks passed
@TomasArrachea TomasArrachea deleted the elcontracts_tests branch November 13, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance version next maintenance version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants