Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add validation to generates 32 bytes keys #60

Closed
wants to merge 2 commits into from
Closed

add validation to generates 32 bytes keys #60

wants to merge 2 commits into from

Conversation

shrimalmadhur
Copy link
Collaborator

@shrimalmadhur shrimalmadhur commented Oct 25, 2023 •
edited
Loading

Fixes #58

Motivation

crypto.GenerateKey() randomly generate 31 bytes private keys. go-ethereum doesn't like that so we are adding validations for that.

Solution

Open questions

@shrimalmadhur shrimalmadhur requested a review from samlaf October 25, 2023 03:28
@shrimalmadhur shrimalmadhur mentioned this pull request Oct 25, 2023
Merged
@shrimalmadhur
Copy link
Collaborator Author

closing since it's handled by #61

@shrimalmadhur shrimalmadhur deleted the madhur/generate-ecdsa-32bytes branch November 1, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samlaf samlaf Awaiting requested review from samlaf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate ECDSA key for 200 operators
1 participant
@shrimalmadhur