Feat/middleware #102
Merged
Feat/middleware #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Functionality - **Synchronous and Asynchronous Support**: The middleware can handle requests in both synchronous and asynchronous modes, determined dynamically at initialization. - **String Representation**: Implements a __repr__ method for easy identification of the middleware instance, showing the callable associated with it. - **Method Stubs**: Defines __sync_call__ and __acall__ methods that must be implemented by subclasses, enforcing a structure for middleware development. This base class serves as a reusable component for developers building custom middleware in Django, ensuring compatibility with both synchronous and asynchronous request flows.
- **Asynchronous Support**: The middleware now implements the __acall__ method, enabling it to handle asynchronous requests effectively while maintaining the functionality of synchronous requests through the existing __sync_call__ method. - **Context Variable Management**: Introduced a context manager to bind relevant request details, such as equest_id, ip_address, and user_agent, improving log traceability and enabling more structured logging. - **SQL Query Logging**: Added functionality to log SQL queries executed during the request lifecycle. The middleware tracks the number of queries executed and logs them conditionally based on the configuration, allowing developers to debug SQL interactions effectively. - **Streaming Content Handling**: Enhanced handling of streaming responses by introducing dedicated synchronous and asynchronous streaming wrappers, ensuring accurate logging during streaming operations. This refactor improves the logging capabilities of the middleware while ensuring it can operate in both sync and async contexts, making it a more robust component for logging request-related information in Django applications. Closes Lazarus-org#95
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
###base middleware:
###request middleware:
equest_id, ip_address, and user_agent, improving log traceability and enabling more structured logging.
This refactor improves the logging capabilities of the middleware while ensuring it can operate in both sync and async contexts, making it a more robust component for logging request-related information in Django applications.
Closes #95