Skip to content

Commit

Permalink
eth,plugin: improve plugin finalize error checks
Browse files Browse the repository at this point in the history
Return invalid data status unless return is okay.
  • Loading branch information
fvalette-ledger committed Jan 28, 2025
1 parent 1ae9750 commit eb07fa3
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src_features/signTx/logic_signTx.c
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,8 @@ __attribute__((noinline)) static uint16_t finalize_parsing_helper(const txContex

pluginFinalize.address = msg_sender;

if (!eth_plugin_call(ETH_PLUGIN_FINALIZE, (void *) &pluginFinalize)) {
if (eth_plugin_call(ETH_PLUGIN_FINALIZE, (void *) &pluginFinalize) <
ETH_PLUGIN_RESULT_SUCCESSFUL) {
PRINTF("Plugin finalize call failed\n");
report_finalize_error();
return APDU_NO_RESPONSE;
Expand Down

0 comments on commit eb07fa3

Please sign in to comment.