Remove txAuthSimple, update hmac-secret, improve cancel, add Stax support #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 10, 2023 15:07
This extension has been removed from WebAuthn Spec here: w3c/webauthn#1386 It could still be used, but there was no concrete usage of it. If it were to be replaced, we should probably consider the payment extension: https://w3c.github.io/secure-payment-confirmation/
FIDO2.1 specification and conformance tools enforce that: The authenticator generates two random 32-byte values (called CredRandomWithUV and CredRandomWithoutUV) and associates them with the credential.
xchapron-ledger
force-pushed
the
xch/stax
branch
5 times, most recently
from
2a0ea53
to
ba85790
Compare
added 3 commits
November 17, 2023 09:31
This field is optional in FIDO2 in some cases, but required in FIDO2.1. Some browser enforces it, see mozilla/authenticator-rs#319 As not including it is an unnecessary optimisation, we rather always put it if it causes compatibiity issue.
xchapron-ledger
force-pushed
the
xch/stax
branch
from
ba85790
to
85e1d76
Compare
yhql
reviewed
Nov 24, 2023
src/ctap2_get_assertion_flow.c
Outdated
| } else { | ||
| ctap2_get_assertion_user_cancel(); | ||
| #ifdef HAVE_NBGL | ||
| app_nbgl_status("Log in cancelled", false, ui_idle, NBGL_NO_TUNE); |
There was a problem hiding this comment.
This one wasn't on the figma design, I'm changing it.
xchapron-ledger
force-pushed
the
xch/stax
branch
from
85e1d76
to
8256eb0
Compare
yhql
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.