Skip to content

Commit

Permalink
fix: device actions bot fix but remind error for fees
Browse files Browse the repository at this point in the history
  • Loading branch information
@qperrot
qperrot committed Jan 20, 2025
1 parent 24da2fb commit 884faf2
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/ten-ties-rush.md
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@ledgerhq/coin-tezos": patch
---

Fix device actions on tezos
6 changes: 5 additions & 1 deletion libs/coin-modules/coin-tezos/src/test/bot-deviceActions.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@ export const acceptTransaction: DeviceAction<Transaction, any> = deviceActionFlo
title: "Delegate Name",
button: SpeculosButton.RIGHT,
},
{
title: "Operation (0)",
button: SpeculosButton.RIGHT,
},
{
title: "Confirm",
button: SpeculosButton.RIGHT,
Expand Down Expand Up @@ -63,7 +67,7 @@ export const acceptTransaction: DeviceAction<Transaction, any> = deviceActionFlo
expectedValue: ({ transaction }) => transaction.recipient,
},
{
title: "Storage Limit",
title: "Storage limit",
button: SpeculosButton.RIGHT,
expectedValue: ({ transaction }) => transaction.storageLimit?.toString() || "",
},
Expand Down

1 comment on commit 884faf2

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Bot] Testing with 'Nitrogen' ❌ 1 txs ($6.66) ⏲ 14.7s

❌ 1 specs have problems: Tezos

What is the bot and how does it work? Everything is documented here!

❌ 1 mutation errors 
necessary accounts resynced in 0.20ms
▬ TezosWallet 3.0.6 on nanoS 2.1.0
→ FROM undefined: 5.28869 XTZ (152ops) (tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF on 44'/1729'/0'/0') tezbox#0 js:2:tezos:0240051fc51799e60dcc8870415b87fc4fd948e71b23fdc0d9b8ac7438cf7d4708:tezbox
max spendable ~5.28774
★ using mutation 'send unrevealed'
→ TO undefined: 0 XTZ (0ops) (tz1SApkt3kmMaqNE1qtgADc6m3B49HZkFVDA on 44'/1729'/2'/0') tezbox#2 js:2:tezos:029d7bcf10737806147b22ba4578747ce4ac53e26b443c9eb1ac0e4d5bfbb8f67e:tezbox
✔️ transaction 
SEND 2.643872 XTZ
TO tz1SApkt3kmMaqNE1qtgADc6m3B49HZkFVDA
with fees=0.0005
with gasLimit=600
with storageLimit=277
(estimatedFees 0.000563)
STATUS (1259ms)
  amount: 2.643872 XTZ
  estimated fees: 0.000563 XTZ
  total spent: 2.644435 XTZ
errors: 
warnings: 
⚠️ TEST deviceAction confirm step 'Fee'
Error: expect(received).toMatchObject(expected)

- Expected  - 1
+ Received  + 1

  Object {
-   "Fee": "0.000563 XTZ",
+   "Fee": "0.000374 XTZ",
  }
(totally spent 4.4s – ends at 2025-01-20T12:39:49.425Z)
⚠️ 1 spec hints
  • Spec Tezos:
    • mutations should define a test(): send unrevealed, send revealed
Details of the 1 mutations

Spec Tezos (3)

Spec Tezos found 3 Tezos accounts (preload: 195ms). Will use TezosWallet 3.0.6 on nanoS 2.1.0
undefined: 5.28869 XTZ (152ops) (tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF on 44'/1729'/0'/0') tezbox#0 js:2:tezos:0240051fc51799e60dcc8870415b87fc4fd948e71b23fdc0d9b8ac7438cf7d4708:tezbox
undefined: 0 XTZ (4ops) (tz1he4fPXP3c9fFrztYT3k7KyYuLb28arFNn on 44'/1729'/1'/0') tezbox#1 js:2:tezos:02fe3d777af5380ef0a431c4985772c9669743050cee5feff717c3c3272d7a2810:tezbox
undefined: 0 XTZ (0ops) (tz1SApkt3kmMaqNE1qtgADc6m3B49HZkFVDA on 44'/1729'/2'/0') tezbox#2 js:2:tezos:029d7bcf10737806147b22ba4578747ce4ac53e26b443c9eb1ac0e4d5bfbb8f67e:tezbox
necessary accounts resynced in 0.20ms
▬ TezosWallet 3.0.6 on nanoS 2.1.0
→ FROM undefined: 5.28869 XTZ (152ops) (tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF on 44'/1729'/0'/0') tezbox#0 js:2:tezos:0240051fc51799e60dcc8870415b87fc4fd948e71b23fdc0d9b8ac7438cf7d4708:tezbox
max spendable ~5.28774
★ using mutation 'send unrevealed'
→ TO undefined: 0 XTZ (0ops) (tz1SApkt3kmMaqNE1qtgADc6m3B49HZkFVDA on 44'/1729'/2'/0') tezbox#2 js:2:tezos:029d7bcf10737806147b22ba4578747ce4ac53e26b443c9eb1ac0e4d5bfbb8f67e:tezbox
✔️ transaction 
SEND 2.643872 XTZ
TO tz1SApkt3kmMaqNE1qtgADc6m3B49HZkFVDA
with fees=0.0005
with gasLimit=600
with storageLimit=277
(estimatedFees 0.000563)
STATUS (1259ms)
  amount: 2.643872 XTZ
  estimated fees: 0.000563 XTZ
  total spent: 2.644435 XTZ
errors: 
warnings: 
⚠️ TEST deviceAction confirm step 'Fee'
Error: expect(received).toMatchObject(expected)

- Expected  - 1
+ Received  + 1

  Object {
-   "Fee": "0.000563 XTZ",
+   "Fee": "0.000374 XTZ",
  }
(totally spent 4.4s – ends at 2025-01-20T12:39:49.428Z)
Details of the 1 uncovered mutations

Spec Tezos (1)

  • send revealed: balance is too low (2)
Portfolio ($6.66) – Details of the 1 currencies
Spec (accounts) State Remaining Runs (est) funds?
Tezos (3) 156 ops , 5.28869 XTZ ($6.66) 💪 911 tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF 
undefined: 5.28869 XTZ (152ops) (tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF on 44'/1729'/0'/0') tezbox#0 js:2:tezos:0240051fc51799e60dcc8870415b87fc4fd948e71b23fdc0d9b8ac7438cf7d4708:tezbox
undefined: 0 XTZ (4ops) (tz1he4fPXP3c9fFrztYT3k7KyYuLb28arFNn on 44'/1729'/1'/0') tezbox#1 js:2:tezos:02fe3d777af5380ef0a431c4985772c9669743050cee5feff717c3c3272d7a2810:tezbox
undefined: 0 XTZ (0ops) (tz1SApkt3kmMaqNE1qtgADc6m3B49HZkFVDA on 44'/1729'/2'/0') tezbox#2 js:2:tezos:029d7bcf10737806147b22ba4578747ce4ac53e26b443c9eb1ac0e4d5bfbb8f67e:tezbox
Performance ⏲ 14.7s

Time spent for each spec: (total across mutations)

Spec (accounts) preload scan re-sync tx status sign op broadcast test destination test
TOTAL 195ms 3.8s 0.51ms 1259ms N/A N/A N/A N/A
Tezos (2) 195ms 3.8s 0.51ms 1259ms N/A N/A N/A N/A

What is the bot and how does it work? Everything is documented here!

Please sign in to comment.