-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Misleading Casper Token #8934
Open
Canestin
wants to merge
6
commits into
develop
Choose a base branch
from
LIVE-15823-remove-misleading-casper-token
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+5
β51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git βοΈ
3 Skipped Deployments
|
live-github-bot
bot
added
the
ledgerjs
Has changes in the ledgerjs open source libs
label
Jan 17, 2025
hedi-edelbloute
requested changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we remove stuff in libs/ledgerjs/packages/cryptoassets/src/tokens.ts also ?
hedi-edelbloute
previously approved these changes
Jan 20, 2025
Canestin
force-pushed
the
LIVE-15823-remove-misleading-casper-token
branch
from
January 20, 2025 08:52
948d2cb
to
91f06d7
Compare
Canestin
force-pushed
the
LIVE-15823-remove-misleading-casper-token
branch
from
January 22, 2025 00:22
91f06d7
to
1b2d4c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
β Checklist
npx changeset
was attached.π Description
Currently, in the code
/ledger-live/libs/ledgerjs/packages/cryptoassets/src/data/casper.ts
, this hardcoded file gives the impression that Casper tokens can be added. However, it seems this was a copy-paste operation. To avoid confusion, we are removing it. If we ever need to support this, we will do it properly with CAL Importers compatibility.β Context
π§ Checklist for the PR Reviewers